Suggested improvements on the Presentations schema #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nissimsan
commented
Jun 17, 2021
nissimsan
commented
- make credentials plural
- refer to the VC schema, not just an object
- make credentials plural - refer to the VC schema, not just an object
nissimsan
requested review from
mkhraisha,
msporny,
OR13 and
peacekeeper
as code owners
msporny
reviewed
Jun 17, 2021
Co-authored-by: Orie Steele <orie@or13.io>
OR13
approved these changes
Jun 22, 2021
msporny
approved these changes
Jun 22, 2021
OR13
approved these changes
Jun 22, 2021
|
I agree with the change itself, but is this the right file to change? I think this file is the "stable" version 0.0.2 that shouldn't be changed anymore. Instead, we should make that change in the current unstable version, i.e. here: https://github.com/w3c-ccg/vc-http-api/blob/main/docs/components/Presentation.yml#L40 Or am I missing something? |
OR13
requested changes
Jun 23, 2021
There was a problem hiding this comment.
@nissimsan @peacekeeper is correct, this change should be made here:
https://github.com/w3c-ccg/vc-http-api/tree/main/docs <- (latest / next)
(not to a fixed version / v0.0.2)
|
Of course, thanks @peacekeeper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.